use local random generator in GCP #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried making the GCP KMS GenerateRandom one work (that's called by libkmsp11 through the crypto11.PKCS11RandReader interface) but we hit rate limits quickly (esp because of Go's use of randutil.MaybeReadByte) and it required a lot of code to fit all reads between 8 and 1024 bytes. See https://cloud.google.com/kms/docs/generate-random#known_limitations Modern Linux systems have a great /dev/urandom and Go uses that. It's security properties are as good or better than HSM implementations. We hadn't even finished the code to use at least 8 bytes, so this avoids even more code churn.
bhearsum
approved these changes
Oct 25, 2024
| @@ -664,262 +662,3 @@ func TestMakeKeyGCPRSA(t *testing.T) { | |||
| t.Fatalf("MakeKey failed: %v", err) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
lmao the life of the engineer 💀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried making the GCP KMS GenerateRandom one work (that's called by
libkmsp11 through the crypto11.PKCS11RandReader interface) but we hit
rate limits quickly (esp because of Go's use of randutil.MaybeReadByte)
and it required a lot of code to fit all reads between 8 and 1024 bytes.
See https://cloud.google.com/kms/docs/generate-random#known_limitations
Modern Linux systems have a great /dev/urandom and Go uses that. It's
security properties are as good or better than HSM implementations.
We hadn't even finished the code to use at least 8 bytes, so this avoids
even more code churn.