correct accidental continous deploys #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of mozilla-services/autograph#1063 (and mozilla-services/autograph#1060). Currently, we're doing a deploy to one of our staging environments on every merge to main this repo. That wasn't desired. Along the way, we also build arm64 versions of the docker image for convenience. See mozilla-services/autograph#1059
jbuck
approved these changes
Nov 19, 2024
jmhodges
added a commit
that referenced
this pull request
Nov 19, 2024
In #337, we reference `make generate` like in the autograph repo. But here that was called `make version.json`. For consistency, and any possible (though, unlikely) additions to what needs to be generate, we rename the make target to `generate` and leave the deploy workflow alone.
jmhodges
added a commit
that referenced
this pull request
Nov 19, 2024
In #337, we reference `make generate` like in the autograph repo. But here that was called `make version.json`. For consistency, and any possible (though, unlikely) additions to what needs to be generate, we rename the make target to `generate` and leave the deploy workflow alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of
mozilla-services/autograph#1063 (and
mozilla-services/autograph#1060).
Currently, we're doing a deploy to one of our staging environments on
every merge to main this repo. That wasn't desired.
Along the way, we also build arm64 versions of the docker image for
convenience. See mozilla-services/autograph#1059