This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
Issue #2325: add some tests for Pocket background fetch #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is more code to be tested so I left TODOs in the test file.
dnarcese
reviewed
May 27, 2019
app/src/test/java/org/mozilla/tv/firefox/pocket/PocketVideoFetchWorkerTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/mozilla/tv/firefox/pocket/PocketVideoFetchWorkerTest.kt
Show resolved
Hide resolved
app/src/test/java/org/mozilla/tv/firefox/pocket/PocketVideoFetchWorkerTest.kt
Show resolved
Hide resolved
dnarcese
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the important items to test in #2325, I'm trying to test each of the classes we wrote thoroughly – as usual, I'm not sure if this is worth the time but given this code is hard to test manually, I want to add as many safeguards as possible to prevent devs from changing it accidentally. :)
Pull Request checklist
qa-readyorqa-denied)