Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-6687 [v116] Settings top/bottom space changed in RTL locale (ar) #15032

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

aalaaeid
Copy link
Contributor

@aalaaeid aalaaeid commented Jun 17, 2023

Jira ticket
Github issue

Description

This fixes the top and bottom spaces of settings cells

Pull requests checks where applicable

  • Fill in the three TODOs above (tickets number and description of your work)
  • The PR name follows our naming guidelines
  • Accessibility implemented and tested (minimum Dynamic Text and VoiceOver)
  • Unit tests written and passing
  • Documentation / comments for complex code and public methods

@aalaaeid aalaaeid requested a review from a team as a code owner June 17, 2023 18:04
@aalaaeid aalaaeid requested a review from lmarceau June 17, 2023 18:04
@lmarceau lmarceau changed the title Bugfix FXIOS-14921 [v116] Settings top/bottom space changed in RTL locale (ar) Bugfix FXIOS-6687 [v116] Settings top/bottom space changed in RTL locale (ar) Jun 19, 2023
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 35.05%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 33.62

File Coverage
ThemedTableViewCell.swift 5.63% ⚠️

Generated by 🚫 Danger Swift against 0ac44c3

@lmarceau lmarceau merged commit 0843d65 into mozilla-mobile:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants