Add support for custom preferences page

[nt1m]

No description provided.

[nt1m]

review?(@kumar303)

[kumar303]

Thanks for the patch. This looks pretty straightforward. It also needs a unit test. You can run the suite with npm test unit; take a look at https://github.com/mozilla-jetpack/jpm/blob/master/test/unit/test.rdf.js

[nt1m]

@kumar303 Thanks for taking a look! Added automated tests.

[kumar303]

nit: typo: missing "if" in the sentence

[kumar303]

The tests look great, thanks. Can you squash it into one commit?

[nt1m]

@kumar303 Done, thanks!

[kumar303]

Hmm. I'm not sure why the suite is failing now. Do you see these same failures locally?

[nt1m]

@kumar303 I can't reproduce locally with npm test. It don't see how squashing commits can cause this. Can you try retriggering the Travis build ?

[kumar303]

I retriggered the build once already, didn't seem to make a difference. Did you rebase on top of the latest master? Might be worth a try.

[freaktechnik]

The failures here seem to be the same as in #546

[kumar303]

You can rebase on master to get a fix for the failing Firefox tests

[kumar303]

The commit message should also be prefixed with feat: (for 'feature') because we've switched to a semantic changelog.

[kumar303]

moved to #549