This repository has been archived by the owner on Nov 27, 2019. It is now read-only.
! Fix error "file already exists" when using command "sign" with XPI file #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b6ad8e to
e31f0e2
Compare
| }); | ||
| unzipper.on("error", function(err) { | ||
| cleanUpAndReject(err); | ||
| }); |
There was a problem hiding this comment.
you can shorten this to unzipper.on("error", cleanUpAndReject)
|
Hey, thanks for the pull request. I've had some really minor comments, but this LGTM otherwise. Not sure if we can cover this problem with a test, was there ever a way to reliably reproduce it? |
|
There is no test for passing in an XPI (path), and I don't know how to set it up :S |
|
Ah don't worry about it, if it's a problem with a third-party lib I think we can do without a test. Do you have time to fix the small nits above? :) |
e31f0e2 to
1358a03
Compare
…file Use another unzip library `decompress-zip` to replace `unzip` due to a potential bug in `unzip`
1358a03 to
22df306
Compare
|
Fixed and all green |
|
👍 Awesome, thanks! |
|
thanks for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use another unzip library
decompress-zipto replaceunzipdue to a potential bug inunzipFixes #458
Tested command locally
Cause of bug:
A library used
unzipcontains a pontential bug: when unzipping a folder in zip, a file is created instead.So the file is created multiple times causing the error.