Change various .allizom.com to .allizom.org #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will run CI locally later to confirm, helm-charts CI currently broken in Travis due to an AWS issue. also, CI would fail on not upticking the chart version after changing the values.yaml (so the default values of the chart). will probably need to add that as well. |
dfc5e62 to
50b7db6
Compare
|
Rebased, and I attempted to bump the correct chart versions. Thanks for taking the time here. |
|
lets rebase and retry CI on #126 once that's in |
50b7db6 to
36c4f17
Compare
|
Rebased onto #126 as it is right now, will update once that merges. |
|
Even after rebase, it fails, probably because I sourced this PR from a different account. I will leave it in failed state and wait for guidance — happy to resubmit with a local branch if that's best. |
|
resolving conflicts and running locally to pass CI then merging. |
cmharlow
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the charts into alignment with DNS, where we have allizom.org but not com. I suspect this is ultimately a no-op, but since I was in the vicinity, submitting for consideration.