landing_worker: add and use git scm support (bug 1895523) #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7a0c70 to
6d5c2f9
Compare
6d5c2f9 to
8998502
Compare
2fc3f2e to
99186b8
Compare
8998502 to
6e8989e
Compare
c87e1df to
fa48b19
Compare
fea63f3 to
5f546c8
Compare
And rename turn get_scm into an scm property.
We do this to have a less HG-specific term that can be reused for other repo types. By removing the little bit of indirection provided by the previous alias method, we lose the None-ification of empty string (which Django forces on blank-able Char form fields), so we instead handle this directly within the worker.
0be5515 to
609cee4
Compare
Co-authored-by: Zeid <2043828+zzzeid@users.noreply.github.com>
all comments addressed, main merged-in
cgsheeh
approved these changes
Dec 19, 2024
src/lando/utils/management/commands/create_environment_repos.py
Outdated
Show resolved
Hide resolved
shtrom
added a commit
that referenced
this pull request
Jan 13, 2025
shtrom
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the refactor for #154.