Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports #3676 and #3682 from ros1 moveit #3247

Closed
wants to merge 11 commits into from

Conversation

rr-mark
Copy link

@rr-mark rr-mark commented Jan 16, 2025

Description

Ports moveit/moveit#3676 and moveit/moveit#3682

Could this be back-ported to humble when merged

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rr-mark rr-mark marked this pull request as draft January 16, 2025 13:45
@rr-mark rr-mark marked this pull request as ready for review January 16, 2025 14:19
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first sight this looks reasonable.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.66%. Comparing base (415a4a2) to head (cf538ca).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...nning_scene_monitor/src/planning_scene_monitor.cpp 83.34% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3247      +/-   ##
==========================================
+ Coverage   45.65%   45.66%   +0.01%     
==========================================
  Files         714      714              
  Lines       62298    62287      -11     
  Branches     7532     7531       -1     
==========================================
- Hits        28437    28436       -1     
+ Misses      33695    33684      -11     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Jan 16, 2025
@rr-mark
Copy link
Author

rr-mark commented Jan 17, 2025

@rhaschke @v4hn This should now be ready to review, when you have time.

@rr-mark
Copy link
Author

rr-mark commented Jan 30, 2025

Closed in favour of #3283

@rr-mark rr-mark closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants