-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSA] Clean up extra parentheses #1366
Conversation
Please target the |
087664b
to
ab84da9
Compare
This pull request is in conflict. Could you fix it @DLu? |
Codecov Report
@@ Coverage Diff @@
## feature/msa #1366 +/- ##
===============================================
+ Coverage 61.28% 61.57% +0.29%
===============================================
Files 274 274
Lines 24929 24965 +36
===============================================
+ Hits 15275 15369 +94
+ Misses 9654 9596 -58
Continue to review full report at Codecov.
|
@@ -57,7 +57,7 @@ void PerceptionConfig::loadPrevious(const std::filesystem::path& package_path, c | |||
} | |||
catch (const std::runtime_error& e) | |||
{ | |||
RCLCPP_ERROR_STREAM((*logger_), e.what()); | |||
RCLCPP_ERROR_STREAM(*logger_, e.what()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use a logger pointer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The namespace for the logger is determined dynamically during the initialization phase and because it is loaded in via pluginlib
, the constructor can't have any parameters.
Description
I had a lot of extra parentheses because of the bug fixed here: ros2/rclcpp#1820
Checklist