-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CallbackGroup in PlanningSceneMonitor #1312
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
+ Coverage 61.48% 61.55% +0.07%
==========================================
Files 274 274
Lines 24940 24943 +3
==========================================
+ Hits 15332 15351 +19
+ Misses 9608 9592 -16
Continue to review full report at Codecov.
|
I switched this back to DRAFT because there are still runtime issues with parameter updates I need to look into first. |
This pull request is in conflict. Could you fix it @henningkayser? |
@henningkayser do you have some documentation you can link to I can read to better understand what the issues are here? Is there some test I can run to see the issues you are experiencing with this change? |
This pull request is in conflict. Could you fix it @henningkayser? |
1 similar comment
This pull request is in conflict. Could you fix it @henningkayser? |
There is a small conflict but it seems like we abandoned this work. I'll create a issue to track it. |
Similar to #1305, this replaces the private node with a CallbackGroup. There are still some issues with the synced parameters that I need to look into before this is really ready. Also, the CallbackGroup should be applied to the CSM as well.