Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused Output class, update php version dependency in composer.json #57

Merged
merged 2 commits into from
Oct 30, 2024
Merged

remove unused Output class, update php version dependency in composer.json #57

merged 2 commits into from
Oct 30, 2024

Conversation

piontuso
Copy link
Contributor

No description provided.

@piontuso
Copy link
Contributor Author

@motou please check and merge, thanks

@motou
Copy link
Owner

motou commented Oct 8, 2024

@piontuso Thanks for the PR, please look at my comment:

I think that the plugin is not ready for php8, hence please make the version range smaller.

@piontuso
Copy link
Contributor Author

piontuso commented Oct 15, 2024 •
edited
Loading

@motou I update php version dependency and made it smaller

@piontuso
Copy link
Contributor Author

@motou any chances to merge my PR this week :) ?

@motou motou self-requested a review October 30, 2024 07:11
@motou motou merged commit 44b1ab2 into motou:master Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motou motou Awaiting requested review from motou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piontuso @motou