docs: fix component preview tab style #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZTL-UwU
commented
Feb 20, 2025
| Before | After |
|---|---|
 |
 |
 |
 |
…code blocks Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Comment on lines
7
to
8
| function createRerender(Component: any) { | ||
| let wrapper: any = null |
There was a problem hiding this comment.
The function createRerender uses the type any for its parameter Component, which can lead to type safety issues. It's recommended to define a more specific type or interface for the component parameter to leverage TypeScript's type checking. Similarly, the variable wrapper is also typed as any, which could be more precisely typed to improve code safety and clarity.
Recommended Change:
function createRerender(Component: VueComponent) {
let wrapper: VueWrapper | null = null
}This change ensures that only Vue components can be passed to createRerender, and wrapper is explicitly typed as either VueWrapper or null.
|
thanks for the PR contribution to improve the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.