Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to laravel 11 #154

Merged

Conversation

brahimrizqHireme
Copy link
Contributor

Update for Laravel 11 support in laravel-permission-mongodb

Description

Updated the composer.json to support Laravel 11. Specifically, I changed the dependency constraints for illuminate/auth, illuminate/contracts, and illuminate/support to be compatible with Laravel 11. Additionally, I updated test cases to use the correct Monolog\Level enum instead of integers for log level assertions.

Motivation and context

This change is required to ensure the mostafamaklad/laravel-permission-mongodb package is compatible with Laravel 11, enabling developers who use the latest version of Laravel to integrate MongoDB-based permission management. It addresses compatibility issues and ensures the package can be used in modern Laravel applications.

If it fixes an open issue, please link to the issue here (if you write fixes #num or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

These changes were tested by running the complete test suite using PHPUnit. The tests were conducted in an environment with PHP 8.3 and MongoDB. All existing tests passed successfully after the changes were made, ensuring that the package functions correctly with the updated dependencies.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@llamorinlabs
Copy link

@mostafamaklad can you change to github action for testing
https://github.com/marketplace/actions/setup-php-action

@mostafamaklad mostafamaklad merged commit 4f75329 into mostafamaklad:master Jul 20, 2024
1 of 2 checks passed
@brahimrizqHireme
Copy link
Contributor Author

Done github actions are now available check this
#155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants