add testId for passcode screen and get id flow #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
swatigoel
requested changes
Nov 8, 2023
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…ction screen Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
swatigoel
requested changes
Nov 30, 2023
components/EditableListItem.tsx
Outdated
| @@ -37,7 +38,9 @@ export const EditableListItem: React.FC<EditableListItemProps> = props => { | |||
| color={Theme.Colors.Icon} | |||
| /> | |||
| <ListItem.Content> | |||
| <ListItem.Title style={{paddingTop: 3}}> | |||
| <ListItem.Title | |||
| {...testIDProps('credentialRegistry')} | |||
There was a problem hiding this comment.
This is common component. Pass testID as prop
There was a problem hiding this comment.
The list used here is not a custom component. It is used from react-native-elements library.
There was a problem hiding this comment.
EditableListItem.tsx is a common component.
As of today it's rendering credential registry with two options - mimoto and esignet
It can be reused somewhere else in future
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
swatigoel
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.