[Inji 434 & INJI 441]: Add events in receiver VC sharing flow and cancel button handle #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alka <prasadalka1998@gmail.com>
… end Signed-off-by: Alka <prasadalka1998@gmail.com>
Signed-off-by: Alka <prasadalka1998@gmail.com>
Signed-off-by: Alka <prasadalka1998@gmail.com>
Signed-off-by: Alka <prasadalka1998@gmail.com>
…g-flow Signed-off-by: Alka Prasad <Alka1703@users.noreply.github.com>
swatigoel
requested changes
Nov 6, 2023
screens/Home/MyVcs/AddVcModal.tsx
Outdated
| @@ -5,7 +5,8 @@ import {OtpVerificationModal} from './OtpVerificationModal'; | |||
| import {IdInputModal} from './IdInputModal'; | |||
| import {useTranslation} from 'react-i18next'; | |||
| import {GET_INDIVIDUAL_ID} from '../../../shared/constants'; | |||
| import {TelemetryConstants} from '../../../shared/telemetry/TelemetryUtils'; | |||
| import {TelemetryConstants} from '../../../shared/telemetry/TelemetryConstants'; | |||
| import {Button, Column} from '../../../components/ui'; | |||
There was a problem hiding this comment.
Removing it. Added by mistake
| on: { | ||
| CANCEL: { | ||
| target: '#request.cancelling', | ||
| actions: ['sendVCSharingTerminatedEvent'], |
There was a problem hiding this comment.
we should rename this to sendVCReceiveTerminatedEvent.
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| on: { | ||
| DISCONNECT: { | ||
| target: 'disconnected', | ||
| actions: ['sendVCSharingDisconnectedEvent'], |
There was a problem hiding this comment.
we should rename this to sendVCReceiveDisconnectedEvent.
| actions: 'setReceiveLogTypeUnverified', | ||
| actions: [ | ||
| 'setReceiveLogTypeUnverified', | ||
| 'sendVcShareFailedEvent', |
There was a problem hiding this comment.
we should rename this to sendVcReceiveFailedEvent.
| @@ -394,6 +420,7 @@ export const requestMachine = | |||
| 'sendVcReceived', | |||
| 'setReceiveLogTypeRegular', | |||
| 'logReceived', | |||
| 'sendVcShareSuccessEvent', | |||
There was a problem hiding this comment.
we should rename this to sendVcReceiveSuccessEvent.
| entry: [ | ||
| 'setReceiveLogTypeDiscarded', | ||
| 'logReceived', | ||
| 'sendVcRejectedEvent', |
There was a problem hiding this comment.
we should rename this to sendVcReceiveRejectedEvent.
| entry: [ | ||
| 'setReceiveLogTypeDiscarded', | ||
| 'logReceived', | ||
| 'sendVcRejectedEvent', |
There was a problem hiding this comment.
we should rename this to sendVcReceiveRejectedEvent.
Signed-off-by: Alka <prasadalka1998@gmail.com>
Signed-off-by: Alka <prasadalka1998@gmail.com>
fb24fa7 to
e57972e
Compare
Signed-off-by: Alka <prasadalka1998@gmail.com>
e57972e to
1f1b417
Compare
swatigoel
approved these changes
Nov 7, 2023
srikanth716
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Nov 23, 2023
…cel button handle (mosip#990) * refactor(INJI-434): rename some variables and functions to meaning names Signed-off-by: Alka <prasadalka1998@gmail.com> * feat(INJI-434): add telemetry events in the VC share flow on verifier end Signed-off-by: Alka <prasadalka1998@gmail.com> * fix(INJI-434): handle cancel button press during vc share Signed-off-by: Alka <prasadalka1998@gmail.com> * fix(INJI-441): handle cancel button press during vc share Signed-off-by: Alka <prasadalka1998@gmail.com> * refactor(INJI-434): extracts telemetry constants to a seperate file Signed-off-by: Alka <prasadalka1998@gmail.com> * refactor(INJI-434): remove unused imports Signed-off-by: Alka <prasadalka1998@gmail.com> * fix(INJI-441): update the CANCEL event on press of cancel button Signed-off-by: Alka <prasadalka1998@gmail.com> * refactor(INJI-434): update the method name Signed-off-by: Alka <prasadalka1998@gmail.com> --------- Signed-off-by: Alka <prasadalka1998@gmail.com> Signed-off-by: Alka Prasad <Alka1703@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mosip.atlassian.net/browse/INJI-441
https://mosip.atlassian.net/browse/INJI-434
Handle cancel button on vc share flow on verifier side
Extract out Telemetry constants to a separate file