Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Inji-436): add telemetry events for app triggered warnings #986

Conversation

PuBHARGAVI
Copy link
Contributor

Telemetry events are added to tack App was reset and VC tampered scenarios

…t event subtype

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…unction

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…on and create an object with telemetry constants

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ck binding_auth_failed error

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
… modal

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
… instead of splitting the error in tsx files

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…all languages

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…emetry-events-for-vc-activation-flow

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…m machines common functions into separate file

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…emetry-events-for-app-triggered-warnings

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
… file

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
App.tsx Outdated
import {MessageOverlay} from './components/MessageOverlay';
import SecureKeystore from 'react-native-secure-keystore';
import {isHardwareKeystoreExists} from './shared/cryptoutil/cryptoUtil';
import i18n from './i18n';
import './shared/flipperConfig';
import {__AppId} from './shared/GlobalVariables';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Copy link
Contributor

@Alka1703 Alka1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swatigoel swatigoel merged commit 7a1178e into mosip:develop Nov 6, 2023
srikanth716 pushed a commit to tw-mosip/inji-wallet that referenced this pull request Nov 23, 2023
…p#986)

* refactor(INJI-435): add enum for flow type,end event status & interact event subtype

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* fix(INJI-435): change flow type value to camel case in getEventType function

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* feat(INJI-435): add start,interact & impression events in vc activation and create an object with telemetry constants

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* feat(INJI-435): add end,error events in vc activation flow

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* feat(INJI-435): increase the pressable area of kebab icon

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* feat: generate impression event only after going into otp modal & track binding_auth_failed error

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-435): move sendImpression event from addVc modal to otp modal

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* fix(INJI-435): add missing impression event in issuer machine

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-435): return bindingAuthFailedError from state machines instead of splitting the error in tsx files

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* fix(INJI-435): add padding and fix the activation status overflow in all languages

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-435): change the telemetry sdk path in package.json

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-435): extract esignetMosipVcItem and existingMosipVcItem machines common functions into separate file

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-435): remove duplicate assignments of selectors

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* feat(INJI-436): add telemetry events to track the app generated warnings

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* fix(INJI-436): remove duplicate telemetry constant import in QR login file

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

* refactor(INJI-436): remove unused app id import in app.tsx

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

---------

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants