-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INJIMOB-631] Mini Card View Home Page Changes #1294
Merged
vijay151096
merged 100 commits into
mosip:develop
from
tw-mosip:inji-631-mini-card-view-home-page-changes
Mar 19, 2024
Merged
[INJIMOB-631] Mini Card View Home Page Changes #1294
vijay151096
merged 100 commits into
mosip:develop
from
tw-mosip:inji-631-mini-card-view-home-page-changes
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ngMosipVcItemMachine Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…r kannada language Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…nents for better usability Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
… as per the wireframe Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ing vc and while doing QR login Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
… card is in loading state Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Alka <prasadalka1998@gmail.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ed in VC Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ainer Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…n to delete the vc from the detailed view Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…n option is selected in kebab menu except for remove vc option Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…r of cards available in home screen Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…b menu option in red color Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…in removal confirmation popup Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…nd detailed view based on isVerified status Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…share with selfie from meatball menu Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…is not found Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…rd-view-home-page-changes Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
…ry kind of disconnect Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
swatigoel
previously requested changes
Mar 4, 2024
vijay151096
reviewed
Mar 4, 2024
vijay151096
reviewed
Mar 4, 2024
…logic to remove bottom section fields from wellknown config supported fields Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ils file Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…item machine Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…yOverlay when calling it Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…-view-home-page-changes Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
…erification pending status as part of another task Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…ssary changes related to menu options Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
…download before saving Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…rd-view-home-page-changes Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
* [INJIMOB-778]: add new localistaion for set and confirm passcode screen Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: add authorization after the biometric unlock Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: add check for biometric and password for the toggle Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: add success toaster message when alternate unlock method is added Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: remove toaster when the app is reopened Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: add locales for succes toaster for biometric toggle Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: refactor to check for the toggle from settings Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: refactor function that handles biometric toggle Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: refactor toggle_biometric_unlock event Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: refactor banner notification to show success message Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> * [INJIMOB-778]: add testID for new components Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> --------- Signed-off-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com> Signed-off-by: PoojaBabusing <115976560+PoojaBabusing@users.noreply.github.com> Co-authored-by: Pooja Babusingh <68894211+PoojaBabusingh@users.noreply.github.com>
* [INJIMOB-784] add face verification consent overlay Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add dismiss for backdrop press Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add pop up for qrlogin flow also Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-864] disable backup button when restoring and vice versa (mosip#1279) Signed-off-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> * [INJIMOB-867] - remove all files including unsynced files and get latest file based on date (mosip#1281) Signed-off-by: Sreenadh S <32409698+sree96@users.noreply.github.com> * [INJIMOB - 865,868] - Fix duplicate VC key for restored VC's and remove metadata if vc file not found (mosip#1283) * [INJIMOB-something] use incremental timestamp for restore and make unload take a flag start time Signed-off-by: Harsh Vardhan <harsh59v@gmail.com> * [INJIMOB-865,868] fix duplicate vckey value for restored vcs and remove vc metadata if file not found Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-869] remove unused method in store.ts machine Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-869] revert removing vc metadata if file not found Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-865] fix tamper vc removal When a VC is tampered, we get the tampered vc popup. Once we press okay button in the popup, we will be refreshing the vc machine's myVcs & recievedVcs context. Due to calling of parallel states, we were having issue with refreshing of myVcs. It is fixed by targeting to init state to refresh Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Signed-off-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> * [INJIMOB-865] remove vc metadata when file is not found Co-authored-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-869] add code comments & fix minor code issues Signed-off-by: Harsh Vardhan <harsh59v@gmail.com> --------- Signed-off-by: Harsh Vardhan <harsh59v@gmail.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Signed-off-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> Co-authored-by: Harsh Vardhan <harsh59v@gmail.com> Co-authored-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Co-authored-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> * [INJIMOB-784] set context after getting the value from store Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] refactor the names and send isConsentGiven value properly to the scan machine event Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-784] store & fetch the face auth consent value with proper types Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * INJIMOB-604 VC Verification Failure Scenarios (mosip#1228) * [INJI-604]: Handle Verification VC Error Scenarios Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-604] remove the card from UI when verify credential is failed and show error overlay Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-604] remove unused actions in existingMosipVcItem and issuers machine Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * INJIMOB-604 Replace Error message overlay with new error screen. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJI-611]: New Error screen implemented Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJI-604]: Transation added for Verification error messages. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJI-604] merge develop and resolve conflicts Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJI-604] remove unnecessary log in error screen Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-604] remove removeVcFromMyVcs action from verify vc failed event and fix typegen warnings Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * INJIMOB-604 : Removing logs and renaming functions Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [INJIMOB-604]: Removing unused method. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [Inji-604]: Fixing the issue of recursive VC deletion during Go Back event in Verification Error screen. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [Inji-604]: Fixing bugs post conflict resolve. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [Inji-604]: Removing unused events and adding translations for Go Back button * [Inji-604]: Removed angle brackets for Technical Error * [Inji-604]: Added ToDo to handle backup * [Inji-604]: Removing isVerified flag from the Existing VC Item Machine. * [Inji-604] iOS crash fixed for Verification error Go Back Button Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> * [Inji-604]: Simplified condition for result in verify Credential call. Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> --------- Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Co-authored-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> * [INJIMOB-784] add styles for the popup Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add locales changes in all languages Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] send consent data using event to qrlogin machine Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] refactor scan and qr machines and remove logs Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add testID for icons and buttons Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add translations for help screen contents Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] add translations for help screen contents Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * [INJIMOB-784] change popup text and alter help screen msg order Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> * Update SendVcScreenController.ts * [INJIMOB-784] refactor actions for show face auth consent screen Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> --------- Signed-off-by: adityankannan-tw <adityan410pm@gmail.com> Signed-off-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> Signed-off-by: Sreenadh S <32409698+sree96@users.noreply.github.com> Signed-off-by: Harsh Vardhan <harsh59v@gmail.com> Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Signed-off-by: BalachandarG <balachandar.g@thoughtworks.com> Signed-off-by: adityankannan-tw <109274996+adityankannan-tw@users.noreply.github.com> Co-authored-by: adityankannan-tw <adityan410pm@gmail.com> Co-authored-by: KiruthikaJeyashankar <81218987+KiruthikaJeyashankar@users.noreply.github.com> Co-authored-by: Sreenadh S <32409698+sree96@users.noreply.github.com> Co-authored-by: Harsh Vardhan <harsh59v@gmail.com> Co-authored-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com> Co-authored-by: balachandarg-tw <115633327+balachandarg-tw@users.noreply.github.com>
…-view-home-page-changes Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
…ng the value each time on new connection Signed-off-by: Alka Prasad <prasadalka1998@gmail.com>
…e and fix storage limit error overlay Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
vijay151096
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Looks Good , Merging it.
The Change is yet to come as a part of INJIMOB-695.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.