[INJICERT-317] rename credential.type to MockVerifiableCredential #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e58b860 to
b8e1a86
Compare
b8e1a86 to
7d94c7f
Compare
vharsh
commented
Aug 1, 2024
| JWTSignatureResponseDto jwtSignatureResponseDto = new JWTSignatureResponseDto(); | ||
| jwtSignatureResponseDto.setJwtSignedData("test-jwt"); | ||
| Mockito.when(signatureService.jwtSign(any())).thenReturn(jwtSignatureResponseDto); | ||
| VCResult vcResult = mockVCIssuancePlugin.getVerifiableCredentialWithLinkedDataProof(vcRequestDto,"holderId",Map.of("accessTokenHash","ACCESS_TOKEN_HASH","client_id","CLIENT_ID")); |
There was a problem hiding this comment.
this shouldn't throw an exception, should I wrap this in a try-catch and assert that no exception is thrown?
There was a problem hiding this comment.
jira task to improve test case added , remove throws from test case.
There was a problem hiding this comment.
jainhitesh9998
approved these changes
Aug 1, 2024
Signed-off-by: Harsh Vardhan <harsh59v@gmail.com>
7d94c7f to
e4f4e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The 2nd value of the credential type should have been
MockVerifiableCredentialto match how it's signed/issued by MOSIP stack.