Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing pyright via npm #735

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Installing pyright via npm #735

merged 5 commits into from
Mar 14, 2022

Conversation

ravi-mosaicml
Copy link
Contributor

Installing pyright via npm, as the pip pyright does not appear to pin versions properly.

Closes #733

Installing pyright via npm, as the pip pyright does not appear to pin versions properly.
@ravi-mosaicml ravi-mosaicml requested a review from Averylamp March 14, 2022 16:27
Copy link
Contributor

@Averylamp Averylamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Averylamp Averylamp mentioned this pull request Mar 14, 2022
@ravi-mosaicml ravi-mosaicml merged commit 4541ff4 into dev Mar 14, 2022
@ravi-mosaicml ravi-mosaicml deleted the ravi/fix_pyright branch March 14, 2022 18:17
@bandish-shah bandish-shah added this to the v0.4.1 milestone Mar 14, 2022
ravi-mosaicml added a commit that referenced this pull request Mar 14, 2022
Installing pyright via npm, as the pip pyright does not appear to pin versions properly.

Closes #733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright version pinning not working
3 participants