Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #731

Merged
merged 17 commits into from
Mar 15, 2022
Merged

Update README.md #731

merged 17 commits into from
Mar 15, 2022

Conversation

moinnadeem
Copy link
Contributor

Adding revised README with Jonathan's feedback, and improved algorithm tables.

@moinnadeem moinnadeem requested a review from jfrankle March 14, 2022 19:22
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good; just some comments throughout


## Quickstart
## 📣 Quickstart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the quickstart (or at least the installation section) up higher? I think it would be helpful if it is above the fold

You can use Composer's speedup methods in two ways:

* Through a standalone **Functional API** (similar to `torch.nn.functional`) that allows you to integrate them into your existing training code.
* Using Composer's built-in **Trainer**, which is designed to be performant and automatically takes care of many of the low-level details of using speedup methods.

#### Example: Functional API [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/Composer_Functional.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move the "open in colab" button to a new line, immediately below the header?

loss = criterion(outputs, labels)
loss.backward()
optimizer.step()
scheduler.step()
```

See the official [Composer Functional API Colab notebook](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/Composer_Functional.ipynb) for more.

#### Example: Trainer [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/up_and_running_with_composer.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment re: moving the open in colab button below.

@bandish-shah bandish-shah added this to the v0.4.1 milestone Mar 14, 2022
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though let's address comments later

@ravi-mosaicml ravi-mosaicml merged commit 977cd1d into dev Mar 15, 2022
@ravi-mosaicml ravi-mosaicml deleted the moin/new_readme branch March 15, 2022 00:12
ravi-mosaicml pushed a commit that referenced this pull request Mar 15, 2022
Revised README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants