-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #731
Update README.md #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good; just some comments throughout
|
||
## Quickstart | ||
## 📣 Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the quickstart (or at least the installation section) up higher? I think it would be helpful if it is above the fold
You can use Composer's speedup methods in two ways: | ||
|
||
* Through a standalone **Functional API** (similar to `torch.nn.functional`) that allows you to integrate them into your existing training code. | ||
* Using Composer's built-in **Trainer**, which is designed to be performant and automatically takes care of many of the low-level details of using speedup methods. | ||
|
||
#### Example: Functional API [](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/Composer_Functional.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe move the "open in colab" button to a new line, immediately below the header?
loss = criterion(outputs, labels) | ||
loss.backward() | ||
optimizer.step() | ||
scheduler.step() | ||
``` | ||
|
||
See the official [Composer Functional API Colab notebook](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/Composer_Functional.ipynb) for more. | ||
|
||
#### Example: Trainer [](https://colab.research.google.com/github/mosaicml/composer/blob/dev/notebooks/up_and_running_with_composer.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment re: moving the open in colab button below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though let's address comments later
Adding revised README with Jonathan's feedback, and improved algorithm tables.