hasattr check for Wandb 0.17.6 #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigning
approved these changes
Aug 8, 2024
dakinggg
reviewed
Aug 8, 2024
While possible, I would prefer to rely on wandb's handling of disabled as it's less code surface for us to own and maintain. This is especially true since we now don't use wandb so it's harder to test things like mocking disabled. If more things break, we can do that, but for now, I'd prefer to leave as is and consider this code as frozen as possible |
dakinggg
approved these changes
Aug 8, 2024
bigning
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wandb 0.17.6 changed disabled mode in this PR: wandb/wandb#8037, which breaks wandb logger when running with disabled mode as certain attributes (entity, project) are not set. This wraps these attributes in a check to see if they exist.
This should not break any internal workflows as we have churned from WandB completely in favor of MLFlow, but it may affect open source users so we should prioritize including in patch release.