Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate deepspeed #3512

Merged
merged 13 commits into from
Aug 2, 2024
Merged

Deprecate deepspeed #3512

merged 13 commits into from
Aug 2, 2024

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Aug 1, 2024

What does this PR do?

This PR deprecates the usage of DeepSpeed in Composer. We have not updated DeepSpeed in a long time and do not actively maintain the integration. Composer is tightly coupled to PyTorch FSDP which provides similar functionality, and we are developing all new functionality on top of FSDP and PyTorch native, not DeepSpeed, for parallelism. Before removal we will provide a migration guide for anyone still using DeepSpeed. In the meantime, users are welcome to open a GitHub issue if they have any trouble.

@dakinggg dakinggg marked this pull request as ready for review August 1, 2024 22:47
@dakinggg dakinggg requested a review from mvpatel2000 August 1, 2024 23:29
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhi-mosaic abhi-mosaic self-requested a review August 2, 2024 01:06
Copy link
Contributor

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FSDP is all you need

@dakinggg dakinggg requested a review from a team as a code owner August 2, 2024 03:52
Copy link
Contributor

@jbloxham jbloxham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two and a half years later and I still am confused by DeepSpeed checkpointing

Copy link

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that all the deepspeed related tests are failing

@dakinggg dakinggg merged commit f261979 into mosaicml:dev Aug 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants