Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MosaicMLLambdaEvalClient #3432

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Remove MosaicMLLambdaEvalClient #3432

merged 2 commits into from
Jul 1, 2024

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Jun 27, 2024

What does this PR do?

No longer works in mcli, removing to reduce confusion

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@aspfohl aspfohl requested a review from mvpatel2000 June 27, 2024 16:54
@aspfohl aspfohl marked this pull request as ready for review June 27, 2024 16:56
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletes it and doesn't deprecate it?

But I think it's fine if it no longer works on the platform...

@mvpatel2000 mvpatel2000 merged commit df0ecf5 into dev Jul 1, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the anna/mlambda branch July 1, 2024 18:38
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants