Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary state dict and load_state_dict functions #3361

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

eracah
Copy link
Contributor

@eracah eracah commented Jun 4, 2024

What does this PR do?

The following items don't need to implement state dict and load_state_dict functions:

  1. DeviceGPU
  2. All the other devices
    • just return {} for state_dict and error for load_state_dict. Do we even need to have these functions implemented?
  3. Loggers
    • just wandb and progress_bar, which are never actually used in practice.

@eracah eracah requested a review from a team as a code owner June 4, 2024 21:34
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleanup!

@eracah eracah enabled auto-merge (squash) June 6, 2024 17:40
@eracah eracah merged commit 26084cd into mosaicml:dev Jun 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants