Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more retry to checkpoint downloading #3164

Merged
merged 3 commits into from
Apr 2, 2024
Merged

add more retry to checkpoint downloading #3164

merged 3 commits into from
Apr 2, 2024

Conversation

bigning
Copy link
Contributor

@bigning bigning commented Apr 2, 2024

what

When run diagnostic on r15z1, we found OCI download error in other two places. Adding the retry to those object store downloading.

test

bigning-debug-cp-loading-2-Cv5Bsh

@bigning bigning marked this pull request as ready for review April 2, 2024 17:10
@bigning bigning changed the title a add more retry to checkpoint downloading Apr 2, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigning bigning enabled auto-merge (squash) April 2, 2024 17:33
@bigning bigning merged commit b0d33c4 into dev Apr 2, 2024
14 checks passed
@bigning bigning deleted the retry_2 branch April 2, 2024 17:38
j316chuck pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants