Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure integration test #2996

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Add azure integration test #2996

merged 3 commits into from
Feb 12, 2024

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Feb 12, 2024

What does this PR do?

Add azure integration test.

Note: We only add one test since under the hood we use libcloud which is tested directly elsewhere

Along for ride, removes a test file which was fully skipped. We added a different file for remote testing with GCS, so this is no longer needed.

Test passes here: https://github.com/mosaicml/composer/actions/runs/7876955247

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner February 12, 2024 18:50
@mvpatel2000 mvpatel2000 requested a review from b-chu February 12, 2024 19:00
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove GCS test?

@mvpatel2000
Copy link
Contributor Author

Why remove GCS test?

See PR description

@mvpatel2000 mvpatel2000 merged commit 6d4575d into dev Feb 12, 2024
28 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/azure-tests branch February 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants