-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioned deprecation warning #2984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smol unit test to try warning?
@mvpatel2000 added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
@irenedea can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Add verisoned deprecation warning * Add __all__ * Add unit test for deprecation warning * Update composer/utils/warnings.py Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com> * Fix pyright --------- Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
This allows us to track deprecations and know immediately when they should be removed.