Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioned deprecation warning #2984

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Add versioned deprecation warning #2984

merged 6 commits into from
Mar 13, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Feb 9, 2024

This allows us to track deprecations and know immediately when they should be removed.

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol unit test to try warning?

@irenedea
Copy link
Contributor Author

irenedea commented Feb 9, 2024

@mvpatel2000 added

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@irenedea irenedea enabled auto-merge (squash) February 9, 2024 04:54
@mvpatel2000
Copy link
Contributor

@irenedea can we merge this?

@irenedea irenedea requested a review from a team as a code owner March 13, 2024 19:22
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@irenedea irenedea merged commit 2d9de19 into mosaicml:dev Mar 13, 2024
14 checks passed
j316chuck pushed a commit that referenced this pull request May 16, 2024
* Add verisoned deprecation warning

* Add __all__

* Add unit test for deprecation warning

* Update composer/utils/warnings.py

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>

* Fix pyright

---------

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants