-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA Docker build flow for PR's #1883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, proof is in the pudding
Holding review until EFA and GPU test lands |
…nto bandish/docker_build
…nto bandish/docker_build
mvpatel2000
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Starting to move Docker builds to GHA. In this PR we:
docker-build.yaml
)gen_docker_matrix.yaml
) to translate an image config YAML and translate it to a GHA matrixPR Docker
workflow (pr-docker.yaml
)IMAGE_NAME
parameterflash-attn
to 0.2.8IMAGE_NAME
pytest
test suite works on Torch 1.13 imagespytest
test suite works with all new images, this will be tested in a follow-up PR that merges the Docker build with thepytest
testing workflowsmosaicml/pytorch
,mosaicml/pytorch_vision
,mosaicml/composer
What issue(s) does this change relate to?
Fixes CO-1064
Fixes CO-1606
Fixes CO-1762
To Do's Before Submitting
mosaicml/ci-staging
repo, migrate off ofmosaicml/jenkins-staging
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)