Print help on run_mosaic_trainer.py, cleaned up verbosity.
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moved the `datadir` onto trainer hparams to avoid an UnusedArgumentWarning 2. Setting the default loglevel to warning 3. Cleaned up warnings to not print a useless extra second line showing the source code of the warning.warn call 4. Cleaned up the launch script to be not-very-verbose by default; but added a -v option for verbosity. 5. If `run_mosaic_trainer.py` is run without args, then the help is printed. Closes #88, #128
jbloxham
approved these changes
Dec 16, 2021
Averylamp
approved these changes
Dec 17, 2021
FYI here is the convention: https://docs.python.org/3/howto/logging-cookbook.html#formatting-styles |
I don't think we need to follow this convention although it does save one evaluation call. %s does lead to bugs when you are printing tuples and items such as that. Becomes more confusing in terms of readability as well |
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
…l#170) 1. Moved the `datadir` onto trainer hparams to avoid an UnusedArgumentWarning 2. Setting the default loglevel to warning 3. Cleaned up warnings to not print a useless extra second line showing the source code of the warning.warn call 4. Cleaned up the launch script to be not-very-verbose by default; but added a -v option for verbosity. 5. If `run_mosaic_trainer.py` is run without args, then the help is printed. Closes mosaicml#88, mosaicml#128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datadironto trainer hparams to avoid an UnusedArgumentWarningrun_mosaic_trainer.pyis run without args, then the help is printed.Closes #88, #128