Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the DDPDataLoader #244

Closed
ravi-mosaicml opened this issue Jan 19, 2022 · 0 comments · Fixed by #245
Closed

Remove the DDPDataLoader #244

ravi-mosaicml opened this issue Jan 19, 2022 · 0 comments · Fixed by #245

Comments

@ravi-mosaicml
Copy link
Contributor

Let's remove the DDPDataLoader and instead move its functionality directly into the training loop -- e.g.

for epoch in epochs:
  if isinstance(state.train_dataloader.sampler, DistributedSampler):
    state.train_dataloader.sampler.set_epoch(int(state.timer.epoch))
ravi-mosaicml added a commit that referenced this issue Jan 19, 2022
@ravi-mosaicml
Removed the DDP data loader
98c173e 
Closes #244
@ravi-mosaicml ravi-mosaicml mentioned this issue Jan 19, 2022
Merged
ravi-mosaicml added a commit that referenced this issue Jan 21, 2022
@ravi-mosaicml
Remove the DDP DataLoader (#245)
4ec0544 
Closes #244
coryMosaicML pushed a commit to coryMosaicML/composer that referenced this issue Feb 23, 2022
@ravi-mosaicml @coryMosaicML
Remove the DDP DataLoader (mosaicml#245)
5574b64 
Closes mosaicml#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the DDP DataLoader mosaicml/composer
1 participant
@ravi-mosaicml