Skip to content

Commit

Permalink
fix (#3234)
Browse files Browse the repository at this point in the history
  • Loading branch information
mvpatel2000 authored and Chuck Tang committed May 16, 2024
1 parent 3e85571 commit 5a7e1aa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/test_notebooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ def test_notebook(notebook: str, device: str, s3_bucket: str):
)
if notebook_name == 'checkpoint_autoresume':
pytest.skip('MNIST dataset download is flaky')
if notebook_name == 'exporting_for_inference':
pytest.skip('MNIST dataset download is flaky')

try:
import boto3
Expand Down
4 changes: 4 additions & 0 deletions tests/utils/object_store/test_gs_object_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from composer.loggers import RemoteUploaderDownloader
from composer.trainer import Trainer
from composer.utils import GCSObjectStore
from composer.optim import DecoupledSGDW
from tests.common import RandomClassificationDataset, SimpleModel


Expand All @@ -28,8 +29,10 @@ def test_gs_object_store_integration_json_auth(expected_use_gcs_sdk_val=True, cl
model = SimpleModel()
train_dataset = RandomClassificationDataset()
train_dataloader = DataLoader(dataset=train_dataset)
optimizer = DecoupledSGDW(model.parameters(), lr=1e-4)
trainer_save = Trainer(
model=model,
optimizer=optimizer,
train_dataloader=train_dataloader,
save_folder='gs://mosaicml-internal-integration-testing/checkpoints/{run_name}',
save_filename='test-model.pt',
Expand All @@ -48,6 +51,7 @@ def test_gs_object_store_integration_json_auth(expected_use_gcs_sdk_val=True, cl

trainer_load = Trainer(
model=model,
optimizer=optimizer,
train_dataloader=train_dataloader,
load_path=f'gs://mosaicml-internal-integration-testing/checkpoints/{run_name}/test-model.pt',
max_duration='2ba',
Expand Down

0 comments on commit 5a7e1aa

Please sign in to comment.