Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround #553 #554

Closed
wants to merge 3 commits into from
Closed

Conversation

PierrickKoch
Copy link
Member

workaround #553

@PierrickKoch
Copy link
Member Author

Test similar to examples/tutorials/noise_ghost_tutorial.py and examples/clients/atrv/ghost_noise_script.py

from morse.builder import *

robot = ATRV()
odom = Odometry()
robot.append(odom)
odom.add_stream('socket')
keyboard = Keyboard()
keyboard.properties(Speed=3)
robot.append(keyboard)
odom.alter(0,classpath='morse.modifiers.odometry_noise.OdometryNoise', gyro_drift=0.00005)

ghost = ATRV()
ghost.make_ghost()
teleport = Teleport()
ghost.append(teleport)
ghost.add_default_interface('socket')

env = Environment("land-1/trees")
env.set_camera_speed(5)
env.create()
import pymorse

with pymorse.Morse() as morse:
    try:
        while morse.is_up():
            odom = morse.robot.odom.get()
            morse.ghost.teleport.publish(odom)
            morse.sleep(.1)
    except KeyboardInterrupt:
        print("Bye.")

@adegroote
Copy link
Contributor

See my proposal in adegroote@b999964,

Through, I'm not completely happy with that with the redundant computation of (dx, dy, dyaw) and the fact that the sensor "do" some computation for the modifier. But it preserves the interface.

@PierrickKoch
Copy link
Member Author

Looks cool to me ! :-)

@adegroote
Copy link
Contributor

Ok I will commit it so. You can merge the two other commits after that .

@PierrickKoch
Copy link
Member Author

Would you mind changing the name OdometryNoiseModifier -> OdometryNoise ?
Since it's already in the modifiers package, 'Modifier' is redundant

@adegroote adegroote closed this Jul 29, 2014
@adegroote
Copy link
Contributor

On 29/Jul - 05:35, Pierrick Koch wrote:

Would you mind changing the name OdometryNoiseModifier -> OdometryNoise ?
Sonce it's already in the modifiers package, 'Modifier' is redundant

Too late.

But yes, we can remove the Modifier noise in the different modifier
classes name, (in a consistent way).
Make sure to adapt data.py accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants