AttributeError on pymorse close()

[pronobis]

When running close() as shown below, I get the exception attached. This is invoked when the roslaunch running my morse and this pymorse app is killed, so it is likely that morse itself is dead by then. Still, it should be possible to close pymorse without error.

            with pymorse.Morse() as morse:
                # Start the node
                node = Node(morse)
                node.spin()
                # Close pymorse
                morse.close(cancel_async_services=True)

Service call failed: unable to connect to service: [Errno 4] Interrupted system call
Traceback (most recent call last):
    morse.close(cancel_async_services=True)
  File "/opt/sara_morse/lib/python3.3/site-packages/pymorse/pymorse.py", line 638, in __exit__
    self.close()
  File "/opt/sara_morse/lib/python3.3/site-packages/pymorse/pymorse.py", line 586, in close
    Morse._asyncore_thread.join(TIMEOUT)
AttributeError: 'NoneType' object has no attribute 'join'

[PierrickKoch]

Could you test with 1ecd5a1
hopefully it will solve your problem :-)

[pronobis]

Well, now I get the following exception instead:

Traceback (most recent call last):
    morse.close(cancel_async_services=True)
  File "/opt/sara_morse/lib/python3.3/site-packages/pymorse/pymorse.py", line 648, in __exit__
    self.close()
  File "/opt/sara_morse/lib/python3.3/site-packages/pymorse/pymorse.py", line 595, in close
    Morse._asyncore_thread.syncstop(TIMEOUT)
AttributeError: 'NoneType' object has no attribute 'syncstop'

[adegroote]

The call to close is unnecessarily, as it is basically call at the end of the with scope (its is the main goal of the with syntax :)).

Otherwise, the issue is that Morse._asyncore_thread is set to None line 597, and accessed again in the second call to close.

[pronobis]

Without that line, pymorse will actually never quit. I was looking for a workaround to that problem hoping that adding cancel_async_services=True will actually kill the async services that block pymorse from closing.

[adegroote]

Could you test df8d098 please ?

[pronobis]

That did the trick as far as I can see.