Fix issues from migrating to clap v3 #1324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
One of the changes of #1319 is the migration from
structopt
toclap
v3 to implement the CLI. However, there are some breaking changes while doing this migration which we were not aware of :Structopt
derive toParser
orSubcommand
. It failed to compile and I added aclap(flatten)
argument. However this made thekey
subcommand disapear (because it is flatten). Another argument (clap(subcommand)
) must be used instead.require_delimiter
was changed torequire_value_delimiter
, but also no longer implyrequire_value_delimiter
. It is thus necessary to add it explicitely for our--ethapi
argument.--reserved-nodes
to be provided multiple times (instead of using a single one with values separated with,
). I applied this change to both the try-runtime CLI and our--ethapi
.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?