Fix getComponentInstallDirectory plugintypes retrieval issue.

[kabalin]

fetch_plugintypes return signature was changed at MDL-79843.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.26%. Comparing base (06df50c) to head (a10b6df).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Bridge/Moodle.php	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #337      +/-   ##
============================================
- Coverage     88.30%   88.26%   -0.04%     
- Complexity      760      761       +1     
============================================
  Files            77       77              
  Lines          2334     2335       +1     
============================================
  Hits           2061     2061              
- Misses          273      274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PhilippImhof]

This will Fix #338; you were a split second faster than me...

(I thought that the comment could be useful because it would link the issue to this PR and close it when merging. Apparently that only works if done by someone with the necessary permissions in the repo.)

[paulholden]

Thanks Ruslan & Philipp 👍

[andrewnicols]

Hi peeps,

I'm just wondering what the ratinoale is for not using \core\component::get_component_directory($component);?

I know that the comment says it's beacuse you don't want to use the static cache:

moodle-plugin-ci/src/Bridge/Moodle.php

Line 103 in 18fe3e1

// Must use reflection to avoid using static cache.

But fetch_plugintypes() uses a static cache anyway.

The original reason for this is described in the commit message of 6138af1

Avoid using static cache in core_component

When installing multiple plugins, core_component's
static cache becomes stale. This is bad when installing
a parent plugin, then a sub-plugin. Use reflection
to gain access to the un-cached method we need.

If this is the case, then we should already be calling \core\component::reset() after placing the new plugin anyway.