Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][debugger] Implement support to debug after hot reload #344

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

thaystg
Copy link
Contributor

@thaystg thaystg commented Jul 15, 2021

Related to this PR:
dotnet/runtime#55722

  • Invalidate locals_variable, debug_information and locations after apply an update.
  • Get new information from runtime.
  • Remove the old breakpoint with the wrong offset and create a new one with the correct offset.

@lambdageek
Copy link
Member

@joj After this, locals and breakpoints should work after hot reload updates a method

@lambdageek
Copy link
Member

Since this will disable the breakpoint in the old method body, if the old method was still executing we won't stop in it anymore. That's probably fine, but we might get surprised customer issues about it since EnC in .net framework works a little differently. But hot reload is not EnC.

@thaystg thaystg merged commit 03850bf into mono:main Jul 15, 2021
mauroa pushed a commit to mauroa/debugger-libs that referenced this pull request Sep 21, 2023
…no#344)

Bumps Microsoft.VisualStudio.Interop from 17.6.35864 to 17.6.35902.

---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Interop
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants