-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for Linux ARM32 (armhf) and ARM64 (aarch64) #1382
Conversation
native/linux-arm-clang/build.cake
Outdated
@@ -0,0 +1,58 @@ | |||
DirectoryPath ROOT_PATH = MakeAbsolute(Directory("../..")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is not complete nor does it work.
Seems libjpeg-turbo is having some issues:
scripts/azure-pipelines.yml
Outdated
vmImage: $(VM_IMAGE_LINUX) | ||
docker: scripts/Docker/ubuntu16/armhf | ||
target: externals-linux | ||
additionalArgs: --buildarch=arm --gnArgs="extra_cflags+=[ '-Wno-psabi' ]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra args are for this issue:
scripts/azure-pipelines.yml
Outdated
displayName: Build Native Linux|arm64 (Linux) | ||
vmImage: $(VM_IMAGE_LINUX) | ||
docker: scripts/Docker/ubuntu16/gcc-cross | ||
dockerArgs: --build-arg TOOLCHAIN_ARCH=aarch64-none-linux-gnu --build-arg FONTCONFIG_ARCH=arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm64 or aarch64 images are built using --build-arg
Co-authored-by: jp2masa <jp2masa@users.noreply.github.com>
@mattleibow the Linux ARM64 bins are almost working, though my app had this error:
@Gillibald should we perhaps update SkiaSharp in Avalonia? |
@jmacato This is targeting the next release. We should be able to update. |
@Gillibald awesome :)) well... guess i cant test stuff out without us updating |
The new version is a 1:1 replacement just bump the version number. We can just create a PR that does that and you could use the CI build. |
@Gillibald yeah please do, so we can check other issues here just in case |
@jmacato what happens if you bump the version of SkiaSharp in your project to the latest preview on NuGet. Unless Avalonia is p/invoking directly, it should work. The versions should be API compatible as I made no breaks in the .NET API. |
@mattleibow i'll try the preview releases first |
I am in the process of creating a PR that changes Avalonia to use the preview. Then you just have to copy the ARM bits manually. |
@Gillibald alright i'll wait for that instead :D |
CI just failed on the emscripten lols. Why now? Who knows. Maybe a rebuild will fix it? |
Hopefully #1387 will fix it... |
any change to build this for v2.80.2 ? |
This is already out on the SkiaSharp.NativeAssets.Linux packages |
Found it , sorry for confusion. |
No prob. Let me know if there are any problems by opening a new issue. Have fun drawing! |
Not working in android |
Description of Change
Add a new Linux architecture: armhf
This is build on Ubuntu 16.04 using the ARM prebuilt toolchain: https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads
Using GCC because of: #1382 (comment)
Test Binaries
Built using Clang:
Built using GCC:
Test NuGet
All the packages are on the preview feed as
v2.80.0-pr.1382.31
:https://aka.ms/skiasharp-eap/index.json
Bugs Fixed