Added additional check for local tag name. #58
Conversation
There was a problem hiding this comment.
This problem is occurring when there is a hidden table/part in the excel document and the new row tag with namespace is added to the XML (with none of the standard row tag attributes needed for parsing rows).
It is safe to just ignore such tags and in our tests - it's working fine.
|
Sorry for taking so long to review this. Could you add a test case that demonstrates this working with an Excel file? |
|
I opened #65 with an alternate fix & test for this. I decided to look at the namespace. I'm not sure http://schemas.openxmlformats.org/spreadsheetml/2006/main is the only legit namespace - I've seen references online to http://purl.oclc.org/ooxml/spreadsheetml/main - so for now I figured anything ending in "/main" is A-OK, as opposed to http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing which we need to ignore. |
|
Closing as I believe #65 fixes this issue |
I am having problems with parsing sheets with "AlternateContent" tags.
For example:
<mc:AlternateContent xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"> <mc:Choice Requires="x14"> <controls> <mc:AlternateContent xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"> <mc:Choice Requires="x14"> <control name="Check Box 47" r:id="rId4" shapeId="47151"> <controlPr autoFill="0" autoLine="0" autoPict="0" defaultSize="0"> <anchor moveWithCells="1"> <from> <xdr:col>15</xdr:col> <xdr:colOff>0</xdr:colOff> <xdr:row>85</xdr:row> <xdr:rowOff>0</xdr:rowOff> </from> <to> <xdr:col>15</xdr:col> <xdr:colOff>247650</xdr:colOff> <xdr:row>85</xdr:row> <xdr:rowOff>0</xdr:rowOff> </to> </anchor> </controlPr> </control> </mc:Choice> </mc:AlternateContent> </controls> </mc:Choice> </mc:AlternateContent>In this case, the
<xdr:row>tag is mistaken for a regular row tag:<row customFormat="1" hidden="1" ht="15" r="1" s="31" spans="1:32">When you try to parse a value for "currentRow" from the "r" element, you get "NullpointerException".