Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an update command #997

Merged
merged 39 commits into from
Apr 7, 2018
Merged

Add an update command #997

merged 39 commits into from
Apr 7, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Mar 11, 2018

Add a php artisan monica:update to handle every commands to run when upgrading from a version to another.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Make sure that the change you propose is the smallest possible.
  • Screenshots are included if the PR changes the UI.
  • If you change the UI, make sure the user experience is consistent with the current interface.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

Merging #997 into master will increase coverage by 0.4%.
The diff coverage is 38.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #997     +/-   ##
==========================================
+ Coverage        38%   38.3%   +0.4%     
  Complexity       11      11             
==========================================
  Files           193     195      +2     
  Lines          5119    5173     +54     
==========================================
+ Hits           1941    1979     +38     
- Misses         3178    3194     +16
Impacted Files Coverage Δ Complexity Δ
app/Console/Commands/LangGenerate.php 0% <ø> (-14.2%) 0 <0> (ø)
app/Console/Kernel.php 100% <ø> (ø) 0 <0> (ø) ⬇️
app/Console/Commands/SetupProduction.php 0% <0%> (ø) 0 <0> (ø) ⬇️
app/Console/Commands/SetupTest.php 0% <0%> (ø) 0 <0> (ø) ⬇️
app/Console/Commands/Helpers/CommandExecutor.php 10% <10%> (ø) 0 <0> (?)
app/Console/Commands/PingVersionServer.php 47.5% <58.4%> (+38.2%) 0 <0> (ø) ⬇️
app/Console/Commands/Update.php 73.4% <73.4%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb87ef8...bd891a4. Read the comment docs.

@asbiin asbiin changed the title Add an update command [wip] Add an update command Apr 1, 2018
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 06:36 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 07:14 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 09:34 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 09:35 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 09:40 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 13:43 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 14:06 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 14:10 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 16:05 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 6, 2018 22:16 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-997 April 7, 2018 08:02 Inactive
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant