Allow multiple imported fields, replace existing #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dccb6ed to
75f5b60
Compare
djaiss
reviewed
Mar 13, 2018
app/Jobs/AddContactFromVCard.php
Outdated
|
|
||
| return $email && $contactField; | ||
| return $contactField->contact; |
There was a problem hiding this comment.
If the contact field is not found above, wouldn't this raise an exception?
|
@barryvdh Thank you very much! I finally got the time to merge this with our recent changes. |
superstrong
pushed a commit
to superstrong/monica
that referenced
this pull request
May 19, 2018
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Fixed failed import jobs and show error message.