Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bit about docker-compose.yml #745

Merged
merged 4 commits into from
Jan 6, 2018

Conversation

barttenbrinke
Copy link

@barttenbrinke barttenbrinke commented Jan 3, 2018

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Make sure that the change you propose is the smallest possible.
  • Screenshots are included if the PR changes the UI.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@djaiss
Copy link
Member

djaiss commented Jan 6, 2018

Thanks a lot for this addition to the documentation @barttenbrinke It's clear and very well written, and will definitely help!

@djaiss djaiss merged commit 860f646 into monicahq:master Jan 6, 2018
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants