Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact creation #688

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Fix contact creation #688

merged 2 commits into from
Dec 13, 2017

Conversation

simhnna
Copy link

@simhnna simhnna commented Dec 12, 2017

Fix #384

@djaiss
Copy link
Member

djaiss commented Dec 13, 2017

Thanks a lot for this fix. You've actually put the file in the right order. Funny how mySQL didn't behave like Postgre does in this case.

@djaiss djaiss merged commit 3738695 into monicahq:master Dec 13, 2017
@simhnna
Copy link
Author

simhnna commented Dec 13, 2017

I have a suspicion, that in MySQL such enforcements aren't checked which could theoretically result in a database that is not valid in Monica's view.

My observations that led to that are this merge request, which fixes a problem which would be fine if the account_id is allowed to be null. The other thing I observed, is that a migration that drops an index is considered invalid by PostgreSQL (it's a migration that was added in the second half of this year, I'm currently mobile so I can't tell you which one exactly it is...)

Someone that knows more about the internals should write a test or two to confirm or deny this...

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot register new user when using Postgres
2 participants