Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug 2fa redirect to unallowed method #6703

Merged
merged 6 commits into from
Nov 5, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: bug 2fa redirect to unallowed method
Bug cause by an input value that tries to do a get request to a post route.

after a failure to verify the 2fa code the url in navbar changes to validate2fa which is a post route.

- set the input value to static string 'dashboard'
  • Loading branch information
efturtle committed Jun 20, 2023
commit 03217d5df3e04cf1718e34fdf71df215dbc4878f
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ monicadump.sql
npm-debug.log*
php-extensions-*.tar.bz2
yarn-error.log
.vscode
1 change: 1 addition & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,4 @@ Geidson Benicio @geidsonc
Maximilian Arzberger @Schlauer-Hax <hax@bbn.family>
Gregor Bigalke @GregTCLTK <greg@bbn.family>
Julián Garcés Rodríguez <juliangarces.jg@gmail.com>
Alberto Cuevas Ocegueda <mexslacker@gmail.com>
2 changes: 1 addition & 1 deletion resources/views/auth/validate2fa.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@section('content')
<div class="container">
<form action="{{ session('oauth') ? route('oauth.validate2fa') : route('validate2fa') }}" method="post">
<input type="hidden" name="url" value="{{ urlencode(url()->current()) }}" />
<input type="hidden" name="url" value="dashboard" />
<div class="row">
<div class="col-12 col-md-6 offset-md-3 offset-md-3-right">
<div class="signup-box">
Expand Down