fix: life event creation with unknown month/day #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a JS problem, current version sends this on create: ``` happened_at "2022-0-0" happened_at_day_unknown false happened_at_month_unknown false ``` Whereas old version sent this: ``` happened_at "2022-1-1" happened_at_day_unknown true happened_at_month_unknown true ``` This issue was introduced by 57b31f6 The strict comparison added in the `updateDate` function in CreateLifeEvent.vue broke it. The values for `this.selectedMonth` and `this.selectedDay` can be numbers/integers or strings, depending on where they come from. Initial values and values set by JS are numbers, whereas values set by user input are strings. Fixes monicahq#5936
|
Good catch, thank you @particleflux |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a JS problem, current version sends this on create:
Whereas old version sent this:
This issue was introduced by 57b31f6
The strict comparison added in the
updateDatefunction in CreateLifeEvent.vue broke it.The values for
this.selectedMonthandthis.selectedDaycan be numbers/integers or strings, depending on where they come from.Initial values and values set by JS are numbers, whereas values set by user input are strings.
Fixes #5936
I guess there might be a nicer approach to this in vue, or in general, though I don't have an idea :)