Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added URLs to be exported in vCards. #5609

Merged
merged 8 commits into from
Oct 19, 2021

Conversation

ABOTlegacy
Copy link

@ABOTlegacy ABOTlegacy commented Oct 13, 2021

As a user who uses Monica that exports contacts via vCards, it would be nice to have the URLs listed under a person's contact info to be included in the vCard export. That way when navigate through phone's contacts, I can click the url to open the corresponding app or web browser for easy access to that contact info.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Backend/models changes

  • Tests have been added for the new code.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2021

CLA assistant check
All committers have signed the CLA.

@ABOTlegacy ABOTlegacy marked this pull request as ready for review October 13, 2021 22:11
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thank you.
You just have to fix the tests ...

@asbiin asbiin merged commit 38429a2 into monicahq:master Oct 19, 2021
@asbiin
Copy link
Member

asbiin commented Oct 19, 2021

thank you @ABOTlegacy !

@github-actions
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants