Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 people tags filter link #5568

Merged
merged 2 commits into from
Oct 8, 2021
Merged

fix: 🐛 people tags filter link #5568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83abf5
fix: :bug: people tags link
nhymxu Oct 5, 2021
b0c23e4
add: contributor name
nhymxu Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ Matthew Fitzgerald @mfitzgerald2 <matt@mfitz.net>
Simon Van Accoleyen @SimonVanacco <simon@vanacco.fr>
Michael Bianco <mike@mikebian.co>
Ben Fesili @benfes
Markus Dick @markusdick
Markus Dick @markusdick
Dung Nguyen @nhymxu
4 changes: 4 additions & 0 deletions app/Http/Controllers/ContactsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ private function contacts(Request $request, bool $active)
return 'tags[]='.urlencode($tag->name);
})->join('&');

if ('' !== $url) {
$url .= '&';
}

if ($tags->count() === 0) {
return redirect()->route('people.index');
} else {
Expand Down