Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Vietnamese language #5343

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

nhymxu
Copy link

@nhymxu nhymxu commented Jul 6, 2021

Translate 95%. Some emotion string will translate soon
image

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2021

CLA assistant check
All committers have signed the CLA.

@nhymxu nhymxu force-pushed the add-vietnamses-language branch from 09853f2 to a38e88a Compare July 6, 2021 17:05
@asbiin
Copy link
Member

asbiin commented Jul 11, 2021

Thank you @nhymxu I will review the translation ASAP as well.
I already see 1 glitch: I think in Vietnamese there is no plural form (all ":count contact|:count contacts" source text). In that case you don't have to add a plural form in the translated text, ex: ":count contact|:count contacts" => ":count liên hệ".
It's based on a laravel code, and you can also see here it's included in Monica.

@nhymxu
Copy link
Author

nhymxu commented Jul 11, 2021

@asbiin
Thank you, I will update this on crowdin when see this source text

@asbiin
Copy link
Member

asbiin commented Jul 11, 2021

@nhymxu actually I have validated all other translations, you can see all not approved text in crowdin: https://crowdin.com/translate/monicahq/12/en-vi?filter=basic&value=5 (select others files too)

@nhymxu
Copy link
Author

nhymxu commented Jul 13, 2021

@asbiin
I updated some string. Except every day|every :number days will translate difference for singular hàng ngày and plural mỗi :number ngày.
Rule same with month and year

@asbiin
Copy link
Member

asbiin commented Jul 13, 2021

@nhymxu That's amazing, thank you! For every day|every :number days and alike, you'll still have to define a unique form, because only the 1st item will be rendered very time. For instance, this text will always be translated as hàng ngày, no matter the number of days ... which is not what we want. I agree it's not exactly the same text, well that's the problem with translations: some times we have to deal with it.

@asbiin asbiin merged commit bf2d570 into monicahq:master Jul 13, 2021
@nhymxu nhymxu mentioned this pull request Jul 20, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants