-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: email field on add person #5097
feat: email field on add person #5097
Conversation
Thanks @iloveitaly. I think this is a nice addition to the product! |
0427a43
to
b793ce7
Compare
@djaiss Great! Looks like I didn't update the assets correctly. Rebased on master and ran |
@iloveitaly you can rebase/merge fix master, where the assets are not needed anymore in the repository. |
4c2941d
to
ab957a6
Compare
@asbiin I think this one is ready to go! Could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some slight changes to made:
95bcc17
to
ed0dc7e
Compare
@asbiin removed changelog entry and applied suggested changes. This should be good to go! |
Co-authored-by: Alexis Saettler <alexis@saettler.org>
ed0dc7e
to
81d33b2
Compare
@asbiin removed the .env file comment. Take another look! |
Thank you @iloveitaly ! |
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request has been automatically locked since there |
Adds an email field to the 'add person' screen. I described why this is a helpful feature and it also paves the way for #5083.
I don't think it makes sense to add this feature to the API at it's strictly a UX improvement and doesn't mutate the data model structure.
cc @djaiss
Checklist
Before submitting the PR
General checks
Front-end changes
Backend/models changes
Other tasks
UNRELEASED
.