fix: fix date you met update UX #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
asbiin
requested changes
Oct 5, 2020
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
…-you-met-defaults-to-today-upon-edit
https://github.com/simonardejr/monica into 1927-fix-for-date-you-met-defaults-to-today-upon-edit
|
Don't know if I've done everything right (fetching, merge, and stuff), but let me know if I need to do anything else 😁 |
|
@simonardejr OK it was fine, but because of the merge of your other PR, this one needs to |
|
I've done the merging and re-run |
…ou-met-defaults-to-today-upon-edit
|
Thank you @simonardejr |
|
😁 👍 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for issue #1927 ("Date you met" defaults to today upon edit, even if "I don't know" was selected previously).
$contact->first_metdoesn't exists, so, the condition is never met and the checkbox isn't checked. Also,v-modelis always set to 'known' inapp.js, making the last radio button checked by default.